ierandra commented on code in PR #1861:
URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1863790387
##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java:
##########
@@ -130,36 +118,19 @@ public class AzureBlobStoreBackend extends
AbstractSharedBackend {
public void setProperties(final Properties properties) {
this.properties = properties;
}
+ private volatile BlobContainerClient azureContainer = null;
- private volatile CloudBlobContainer azureContainer = null;
-
- protected CloudBlobContainer getAzureContainer() throws DataStoreException
{
+ protected BlobContainerClient getAzureContainer() throws
DataStoreException {
if (azureContainer == null) {
synchronized (this) {
if (azureContainer == null) {
- azureContainer =
azureBlobContainerProvider.getBlobContainer(getBlobRequestOptions());
+ azureContainer =
azureBlobContainerProvider.getBlobContainer(retryOptions, isProxyNeeded,
properties);
}
}
}
return azureContainer;
}
- @NotNull
- protected BlobRequestOptions getBlobRequestOptions() {
- BlobRequestOptions requestOptions = new BlobRequestOptions();
- if (null != retryPolicy) {
- requestOptions.setRetryPolicyFactory(retryPolicy);
- }
- if (null != requestTimeout) {
- requestOptions.setTimeoutIntervalInMs(requestTimeout);
- }
- requestOptions.setConcurrentRequestCount(concurrentRequestCount);
- if (enableSecondaryLocation) {
-
requestOptions.setLocationMode(LocationMode.PRIMARY_THEN_SECONDARY);
Review Comment:
I see you removed the secondary location concept. How was this implemented
in azure sdk v12 ? because I cannot see it anyware
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
