Amoratinos commented on code in PR #1882:
URL: https://github.com/apache/jackrabbit-oak/pull/1882#discussion_r1862479510
##########
oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConstants.java:
##########
@@ -265,4 +265,12 @@ public interface UserConstants {
* @since Oak 1.3.3
*/
int PASSWORD_HISTORY_DISABLED_SIZE = 0;
+
+ /**
+ * Optional configuration parameter indicating if the anonymous user can
be disabled or not.
+ * By default, the anonymous user can be disabled.
+ *
+ * @since Oak 1.73.0
Review Comment:
Ok, I wasn't aware of this. I took it based from the pom.xml. Will change it
to 1.74 then .
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserImpl.java:
##########
@@ -148,6 +150,16 @@ public void disable(@Nullable String reason) throws
RepositoryException {
}
}
+ private void canDisableUser() throws RepositoryException {
Review Comment:
I'm also not happy with it. Initially I call it `validateCanDisableUser` but
again I dislike it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
