thomasmueller commented on code in PR #1673:
URL: https://github.com/apache/jackrabbit-oak/pull/1673#discussion_r1741585122
##########
oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/package-info.java:
##########
@@ -18,7 +18,7 @@
/**
* This package contains oak query index related classes.
*/
-@Version("2.0.0")
+@Version("3.0.0")
Review Comment:
The "QueryLimits" has a new method "getImprovedIsNullCost", I think that's
why: the build broke without this change. I can try to add a default
implementation in for the new method if you think the version bump is a problem?
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java:
##########
@@ -584,6 +584,10 @@ public Oak with(@NotNull Whiteboard whiteboard) {
LOG.info("Registered Prefetch feature: " +
QueryEngineSettings.FT_NAME_PREFETCH_FOR_QUERIES);
closer.register(prefetchFeature);
queryEngineSettings.setPrefetchFeature(prefetchFeature);
+ Feature improvedIsNullCostFeature =
newFeature(QueryEngineSettings.FT_NAME_IMPROVED_IS_NULL_COST, whiteboard);
Review Comment:
BTW if no feature toggle is set, then it is enabled. So the feature toggle
is more about the ability to (temporarily) switch to the old behavior, in case
of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
