nit0906 commented on code in PR #1673:
URL: https://github.com/apache/jackrabbit-oak/pull/1673#discussion_r1741376610


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java:
##########
@@ -584,6 +584,10 @@ public Oak with(@NotNull Whiteboard whiteboard) {
             LOG.info("Registered Prefetch feature: " + 
QueryEngineSettings.FT_NAME_PREFETCH_FOR_QUERIES);
             closer.register(prefetchFeature);
             queryEngineSettings.setPrefetchFeature(prefetchFeature);
+            Feature improvedIsNullCostFeature = 
newFeature(QueryEngineSettings.FT_NAME_IMPROVED_IS_NULL_COST, whiteboard);

Review Comment:
   I would argue this being behind a "feature" toggle - it's more of fixing an 
incorrect behaviour for me. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to