stefan-egli commented on PR #1619: URL: https://github.com/apache/jackrabbit-oak/pull/1619#issuecomment-2285695884
On the test methods that seem to have gotten lost, here's a list of them - those existed prior to this PR and now seem gone (unless renamed) : ``` uncompressValueThrowsException multiValuedAboveThresholdSize stringAboveThresholdSizeNoCompression testEqualsWithoutCompression testInterestingStringsWithoutCompression testOneCompressOtherUncompressInEquals uncompressValueThrowsException ``` Also noticed that `stringBelowThresholdSize` actually tests _below_ threshold - so either the test name or the test code is wrong. Also, as a general comment : I think it would be useful to go via the factory method whenever possible. That would extend the test coverage of the factory method - which is a very key element. (I think this would be the lost prio comment though) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
