stefan-egli commented on PR #1619: URL: https://github.com/apache/jackrabbit-oak/pull/1619#issuecomment-2284096577
(Adding a general comment here in the main discussion as it otherwise might be getting a bit complicated by now) What I was trying to say: the fact that the `DocumentPropertyStateTest` got refactored into 3 different classes lost a few aspects and thus results in a regression. * as mentioned I believe some test methods got lost (I will double-check and can add more details) * in addition though, some of the `@Before` and `@After` logic got lost - which actually is also a regression. For example, the broken surrogate tests no longer work as they were intended - they now inherit the threshold from whatever test/test-method was executed before, which is breaking change from the previous behavior (I think previously they tested with `-1`) * (and the `-1` bug mentioned several times is thus still undetected by tests and is still existing in the code) Plus what is also a regression vs the previous state is what I mentioned previously: > Also, compressValueThrowsException : now expects an exception while previously it didn't? Previously the constructor was swallowing those exceptions, which I think is a good thing. Now that has been changed. Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
