[
https://issues.apache.org/jira/browse/THRIFT-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-6319:
-------------------------------
Description:
{{lib/ts/Makefile.am}} defines
{code}
check-local: prereq all
./node_modules/.bin/grunt
{code}
but nothing ever enters that directory:
* {{lib/Makefile.am}} lists {{ts}} only in {{EXTRA_DIST}}; it appears in no
{{SUBDIRS}} block.
* {{configure.ac}} has no {{AX_THRIFT_LIB(ts, ...)}}, so there is no
{{--with-ts}} / {{--without-ts}}
at all. {{lib/ts/Makefile}} is generated (configure.ac line 830) and then
never used.
* {{.github/workflows/build.yml}} has no top-level {{make check}}. Every job
runs
{{make -C lib/<lang> check}}, and the full set is dart, d, erl, go, java,
kotlin, lua, netstd,
nodejs, nodets, php, py, rb and rs. Neither {{js}} nor {{ts}} is among them.
For contrast, {{lib/js}} is at least reachable: {{lib/Makefile.am}} adds it to
{{SUBDIRS}} inside
the {{if WITH_JAVA}} block, because its test needs java and ant.
Consequence: every change to the lib/ts test toolchain is unverified. That is
the substance
behind the review remarks on
[PR #3747|https://github.com/apache/thrift/pull/3747].
Order of work: {{THRIFT-6317}} (the TypeScript compile error) and
{{THRIFT-6318}} (the
browserify/uuid parse error) have to go first
-- they make {{make -C lib/ts check}} pass at all -- and only then does wiring
it up buy anything.
Drafted with AI assistance (Claude Opus 5).
was:
{{lib/ts/Makefile.am}} defines
{code}
check-local: prereq all
./node_modules/.bin/grunt
{code}
but nothing ever enters that directory:
* {{lib/Makefile.am}} lists {{ts}} only in {{EXTRA_DIST}}; it appears in no
{{SUBDIRS}} block.
* {{configure.ac}} has no {{AX_THRIFT_LIB(ts, ...)}}, so there is no
{{--with-ts}} / {{--without-ts}}
at all. {{lib/ts/Makefile}} is generated (configure.ac line 830) and then
never used.
* {{.github/workflows/build.yml}} has no top-level {{make check}}. Every job
runs
{{make -C lib/<lang> check}}, and the full set is dart, d, erl, go, java,
kotlin, lua, netstd,
nodejs, nodets, php, py, rb and rs. Neither {{js}} nor {{ts}} is among them.
For contrast, {{lib/js}} is at least reachable: {{lib/Makefile.am}} adds it to
{{SUBDIRS}} inside
the {{if WITH_JAVA}} block, because its test needs java and ant.
Consequence: every change to the lib/ts test toolchain is unverified. That is
the substance
behind the review remarks on
[PR #3747|https://github.com/apache/thrift/pull/3747].
Order of work: the TypeScript compile error and the browserify/uuid parse error
have to go first
-- they make {{make -C lib/ts check}} pass at all -- and only then does wiring
it up buy anything.
Drafted with AI assistance (Claude Opus 5).
> lib/ts is not part of the build, so its check-local target never runs
> ---------------------------------------------------------------------
>
> Key: THRIFT-6319
> URL: https://issues.apache.org/jira/browse/THRIFT-6319
> Project: Thrift
> Issue Type: Bug
> Components: Build Process, TypeScript - Library
> Reporter: Jens Geyer
> Priority: Major
>
> {{lib/ts/Makefile.am}} defines
> {code}
> check-local: prereq all
> ./node_modules/.bin/grunt
> {code}
> but nothing ever enters that directory:
> * {{lib/Makefile.am}} lists {{ts}} only in {{EXTRA_DIST}}; it appears in no
> {{SUBDIRS}} block.
> * {{configure.ac}} has no {{AX_THRIFT_LIB(ts, ...)}}, so there is no
> {{--with-ts}} / {{--without-ts}}
> at all. {{lib/ts/Makefile}} is generated (configure.ac line 830) and then
> never used.
> * {{.github/workflows/build.yml}} has no top-level {{make check}}. Every job
> runs
> {{make -C lib/<lang> check}}, and the full set is dart, d, erl, go, java,
> kotlin, lua, netstd,
> nodejs, nodets, php, py, rb and rs. Neither {{js}} nor {{ts}} is among them.
> For contrast, {{lib/js}} is at least reachable: {{lib/Makefile.am}} adds it
> to {{SUBDIRS}} inside
> the {{if WITH_JAVA}} block, because its test needs java and ant.
> Consequence: every change to the lib/ts test toolchain is unverified. That is
> the substance
> behind the review remarks on
> [PR #3747|https://github.com/apache/thrift/pull/3747].
> Order of work: {{THRIFT-6317}} (the TypeScript compile error) and
> {{THRIFT-6318}} (the
> browserify/uuid parse error) have to go first
> -- they make {{make -C lib/ts check}} pass at all -- and only then does
> wiring it up buy anything.
> Drafted with AI assistance (Claude Opus 5).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
