Jens Geyer created THRIFT-6318:
----------------------------------
Summary: lib/ts: browserify 16 cannot parse the current uuid
package
Key: THRIFT-6318
URL: https://issues.apache.org/jira/browse/THRIFT-6318
Project: Thrift
Issue Type: Bug
Components: TypeScript - Library
Reporter: Jens Geyer
With the TypeScript compile error worked around locally, the next grunt task in
{{make -C lib/ts check}} fails:
{code}
Running "shell:BrowserifyCompiledTS" (shell) task
>> Error: Parsing file /<root>/node_modules/uuid/dist/cjs-browser/v4.js:
>> Unexpected token (11:33)
>> at Deps.parseDeps (.../module-deps/index.js:510:15)
{code}
{{lib/ts/package.json}} pins {{browserify}} at {{^16.2.3}} (2018). Its bundled
acorn does not
parse the syntax of the current {{uuid}} package, which the root {{npm
install}} -- run by
grunt's own {{shell:InstallThriftNodeJSDep}} task -- pulls into
{{<root>/node_modules}}.
Reproduced on master {{6b1d360e7}} and, identically, on
[PR #3747|https://github.com/apache/thrift/pull/3747] (there the parse error
lands on
{{cjs-browser/v1.js}} instead of {{v4.js}}; same cause). Node 22.23.2.
Together with the TypeScript compile error this is why the lib/ts browser test
never reaches its
QUnit step.
Drafted with AI assistance (Claude Opus 5).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
