Yicong-Huang commented on code in PR #8463:
URL: https://github.com/apache/texera/pull/8463#discussion_r4058951466
##########
frontend/src/app/app.module.ts:
##########
@@ -330,15 +328,13 @@ registerLocaleData(en);
CollabWrapperComponent,
AboutComponent,
TexeraLoginComponent,
- UserWorkflowListItemComponent,
SortButtonComponent,
FiltersComponent,
FiltersInstructionsComponent,
SearchComponent,
PortPropertyEditFrameComponent,
WorkflowRuntimeStatisticsComponent,
FlarumComponent,
- HighlightSearchTermsPipe,
SearchBarComponent,
ListItemComponent,
Review Comment:
**Advisory:**
The cleanup stops one file short.
`dashboard/component/section-style.scss:130-199` sits under the comment "css
specifically for each workflow item in the list". It holds
`.workflow-list-item` and everything nested under it, plus the
`.metadata-container` rules at `:123` and `:213`. Base-tree grep shows the
deleted `user-workflow-list-item.component.html` was the sole applier of every
one of those classes. That leaves roughly 70 dead lines in a partial seven
component stylesheets `@use`. Dead CSS renders nothing, so no behavior is wrong
either way, but it is the same deletion, and leaving it means the next person
redoes this grep. One dangling reference goes with it:
`search-results.component.html:27` cites `.workflow-list-item` as the authority
for `itemSize="70"`, already stale since #2793.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
