aglinxinyuan opened a new pull request, #8463: URL: https://github.com/apache/texera/pull/8463
### What changes were proposed in this PR? Deletes `UserWorkflowListItemComponent`, which is declared in `AppModule` but whose selector `texera-user-workflow-list-item` appears in no template — so it is never rendered. `HighlightSearchTermsPipe` goes with it, because the component's own template is the pipe's last remaining consumer. Pure deletion, no behaviour change: **−1,104 lines**. ### History | | | | --- | --- | | **Introduced by** | #1937 (2023-05-30) — "Refactored each workflow list item into its own component" | | **Usage removed by** | #2793 (2024-08-20) — "Generalize List Item" replaced it with the generic `ListItemComponent`, deleting the last two `texera-user-workflow-list-item` uses from `search-results.component.html` | Dead for about two years. > Reviewer note — why the pipe is in the same PR. `HighlightSearchTermsPipe` arrived in #2386 and kept a second consumer until #7463 (2026-08-29, "remove the deprecated project feature") dropped `entry.name | highlightSearchTerms` from that template. Since then its only use is this dead component's template (L43/L106). Removing the component alone would leave the pipe dead in the same commit, so they ship together; splitting them would just create a second PR for code this one already orphans. > Nothing else needs cleaning: `WorkflowExecutionHistoryComponent`, `ShareAccessComponent`, `DownloadService`, `GuiConfigService` and `WorkflowPersistService` all keep other consumers. ### Any related issues, documentation, discussions? Closes #8460 ### How was this PR tested? Existing tests only — this PR removes a component, a pipe, and the two specs that covered them. From `frontend/`: - `npx ng build` — **success**. This is the gate that matters here: removing an `AppModule` declaration can only be proven safe by an AOT build, since template diagnostics are AOT-only. A leftover use of either selector would fail it. - `npx ng test --watch=false --include='**/user-workflow.component.spec.ts'` — 75 tests pass after dropping the two inert `TestBed` references. - `yarn --cwd frontend format:ci` — clean. Verification, re-runnable by a reviewer: ``` git grep -n "texera-user-workflow-list-item\|UserWorkflowListItemComponent" git grep -n "highlightSearchTerms\|HighlightSearchTermsPipe" ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
