aglinxinyuan opened a new pull request, #8614: URL: https://github.com/apache/texera/pull/8614
### What changes were proposed in this PR? Removes three `PresetService` members that no production code calls: `updateOrCreatePreset`, `isValidNewOperatorPreset`, and the exported `PresetDictionary` type. Pure deletion, no behaviour change: **−175 lines**. ### History | | | | --- | --- | | **Introduced by** | #1164 (2022-01-13) — "Add PresetService (User Presets Step 3)", which built out the preset API surface | | **Usage removed by** | **never wired up** — no production file has ever called `updateOrCreatePreset` or `isValidNewOperatorPreset`, and `PresetDictionary` has zero references worktree-wide. Only the service's own spec exercises them | > Reviewer note: the wired-up half of the service stays — `savePresets`, `getPresets`, `applyPreset`, `isValidOperatorPreset`, `isValidPreset` and the Ajv type guards all keep live consumers. `common/formly/preset-wrapper/**` calls none of the removed three (checked line by line in both the `.ts` and the `.html`). Note `isValidOperatorPreset` (live) and `isValidNewOperatorPreset` (removed) differ by one word — only the latter goes. ### Any related issues, documentation, discussions? Closes #8611 ### How was this PR tested? Existing tests only — this PR removes methods and the spec blocks that covered them. From `frontend/`: - `npx ng test --watch=false --include='**/preset.service.spec.ts'` — 48 tests pass. - `yarn --cwd frontend format:ci` — clean. Verification, re-runnable by a reviewer: ``` git grep -n "updateOrCreatePreset\|isValidNewOperatorPreset\|PresetDictionary" git grep -n isValidOperatorPreset # the live sibling, untouched ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
