aglinxinyuan opened a new pull request, #8613:
URL: https://github.com/apache/texera/pull/8613
### What changes were proposed in this PR?
Removes `AgentService`'s scroll-to-step request stream, which can never
fire. Pure deletion, no behaviour change: **−74 lines**.
The chain exists end to end but has no trigger: `requestScrollToStep()` is
the only producer and nothing calls it, so `scrollToStepSubject` never emits,
the `agent-chat` subscriber never runs, and the private `scrollToStep()` it
dispatches to is unreachable.
```
(no caller) -> requestScrollToStep() -> scrollToStepSubject ->
agent-chat subscriber -> scrollToStep()
^ the chain starts here and nothing ever enters it
```
### History
| | |
| --- | --- |
| **Introduced by** | #4495 (2026-04-27) — "feat(agent-service): add
`agent-service` that manages LLM agents", which shipped the whole chain at once
|
| **Usage removed by** | **never wired up** — no file outside
`agent.service.ts` has called `requestScrollToStep` at any point in the
history, and no UI control invokes it |
> Reviewer note: the sibling `showPortShapes$` stream in the same "canvas
annotation state" block **is** live and is untouched; only the scroll-to-step
members and the section comment's mention of them change. `scrollToMessage` and
`setHoveredMessage`, which the dead handler called, both keep other callers.
### Any related issues, documentation, discussions?
Closes #8610
### How was this PR tested?
Existing tests only — this PR removes code and the tests that covered it.
From `frontend/`:
- `npx ng test --watch=false --include='**/agent.service.spec.ts'
--include='**/agent-chat.component.spec.ts'
--include='**/agent-panel.component.spec.ts'` — 193 tests pass across the three
files.
- `yarn --cwd frontend format:ci` — clean.
Verification, re-runnable by a reviewer:
```
git grep -nF 'scrollToStep$' # use -F: a trailing $ is a regex anchor
git grep -n requestScrollToStep
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
