xuang7 commented on code in PR #8071:
URL: https://github.com/apache/texera/pull/8071#discussion_r4054417868
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
Review Comment:
Done: the list is now derived at run time from the bundle's own
docker-compose.yml (every ${IMAGE_REGISTRY}/texera-* image it pulls), so it
can't drift from what voters download. The prose around it was also trimmed.
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-runner:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-compiling-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-file-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-config-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-access-control-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-agent-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${IMAGE_TAG}
-== Git Tag ==
+These images were built from the source tarball included in this release
candidate.
+
+== Git Tag and Commit ==
https://github.com/apache/texera/releases/tag/${TAG_NAME}
+
Commit: ${COMMIT_HASH}
-== Keys ==
+== KEYS ==
+
+https://downloads.apache.org/incubator/texera/KEYS
+
+The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL}).
-The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL})
-KEYS file: https://downloads.apache.org/incubator/texera/KEYS
+== Major Changes Since <PREVIOUS_RELEASE, e.g. Apache Texera 1.1.0-incubating>
==
+
+Full diff:
+https://github.com/apache/texera/compare/<PREVIOUS_TAG>...${TAG_NAME}
+
+Major changes include:
+<FILL IN: grouped highlights, verified against the previous release BRANCH,
+not its tag>
== Vote ==
-The vote will be open for at least 72 hours.
+The vote will remain open for at least 72 hours.
[ ] +1 Approve the release
[ ] 0 No opinion
-[ ] -1 Disapprove the release (please provide the reason)
+[ ] -1 Do not approve the release because...
== Checklist ==
+Please include the checklist below in your reply and mark the checks you
+performed with an x.
Review Comment:
Done both: the template is now .github/release/vote-email-template.txt with
natural unwrapped lines. A side benefit of .txt: .licenserc.yaml ignores it, so
the generated email no longer starts with the ASF license comment.
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -261,6 +261,9 @@ jobs:
RC_DIR="${{ steps.vars.outputs.rc_dir }}"
COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
IMAGE_REGISTRY="${{ steps.vars.outputs.image_registry }}"
+ # Container images for an RC are tagged with the RC tag (leading
+ # "v" stripped), e.g. v1.2.0-incubating-rc1 -> 1.2.0-incubating-rc1.
+ IMAGE_TAG="${TAG_NAME#v}"
Review Comment:
Done: the step now reuses steps.vars.outputs.image_tag, the same value the
compose bundle writes into the shipped .env, and the summary's "Next Steps"
line uses it as well, so the workflow is down to one spelling.
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-runner:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-compiling-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-file-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-config-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-access-control-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-agent-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${IMAGE_TAG}
Review Comment:
Covered by the dynamic list: on today's main it yields 10 images, including
texera-notebook-migration-service and texera-jupyter.
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
Review Comment:
Done: docs/contribution-guidelines/release-email-template.md no longer
carries a copy; it now points at the canonical template and describes what the
workflow fills in.
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-runner:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-compiling-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-file-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-config-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-access-control-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-agent-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${IMAGE_TAG}
-== Git Tag ==
+These images were built from the source tarball included in this release
candidate.
+
+== Git Tag and Commit ==
https://github.com/apache/texera/releases/tag/${TAG_NAME}
+
Commit: ${COMMIT_HASH}
-== Keys ==
+== KEYS ==
+
+https://downloads.apache.org/incubator/texera/KEYS
+
+The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL}).
-The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL})
-KEYS file: https://downloads.apache.org/incubator/texera/KEYS
+== Major Changes Since <PREVIOUS_RELEASE, e.g. Apache Texera 1.1.0-incubating>
==
+
+Full diff:
+https://github.com/apache/texera/compare/<PREVIOUS_TAG>...${TAG_NAME}
+
+Major changes include:
+<FILL IN: grouped highlights, verified against the previous release BRANCH,
+not its tag>
== Vote ==
-The vote will be open for at least 72 hours.
+The vote will remain open for at least 72 hours.
[ ] +1 Approve the release
[ ] 0 No opinion
-[ ] -1 Disapprove the release (please provide the reason)
+[ ] -1 Do not approve the release because...
== Checklist ==
+Please include the checklist below in your reply and mark the checks you
+performed with an x.
+
[ ] Checksums and PGP signatures are valid
[ ] LICENSE and NOTICE files are correct
[ ] All files have ASF license headers where appropriate
-[ ] No unexpected binary files
[ ] Source tarball matches the Git tag
-[ ] Can compile from source successfully
-[ ] Docker Compose bundle deploys successfully with the published images
+[ ] Docker Compose deploys successfully
Review Comment:
Good point, restored both: "No unexpected binary files" and "Can compile
from source successfully" are back in the checklist.
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -278,6 +281,7 @@ jobs:
sed -i "s|\${GPG_KEY_ID}|${GPG_KEY_ID}|g" vote-email.txt
sed -i "s|\${GPG_EMAIL}|${GPG_EMAIL}|g" vote-email.txt
sed -i "s|\${IMAGE_REGISTRY}|${IMAGE_REGISTRY}|g" vote-email.txt
+ sed -i "s|\${IMAGE_TAG}|${IMAGE_TAG}|g" vote-email.txt
echo "✓ Vote email template generated!"
Review Comment:
Done: the step now greps for remaining <...> / unsubstituted ${...} markers
and prints them with "fill in the placeholders above before sending"; it only
claims a clean generation when none are left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
