xuang7 commented on PR #8071:
URL: https://github.com/apache/texera/pull/8071#issuecomment-5744700649
Thanks for the thorough review — all four must-fixes and the advisories are
addressed in the reworked commit:
1. **Image tag**: the generate step now reuses
`steps.vars.outputs.image_tag` (the value the bundle's `.env` pins); the
summary's "Next Steps" line uses it too, so the workflow has one spelling.
2. **Image list**: derived at run time from the tag's
`bin/single-node/docker-compose.yml` (all `${IMAGE_REGISTRY}/texera-*` images),
so `notebook-migration-service` and `jupyter` are included and future additions
cannot be missed.
3. **Docs copy**: `docs/contribution-guidelines/release-email-template.md`
is now a pointer to the canonical template instead of a second copy.
4. **PR description**: retitled to `ci:`, added the RC4 vote-thread
discussion link, corrected the image counts, and documented a local end-to-end
simulation of the generation pipeline (the step is unreachable from PR CI).
Advisories: the template is now a `.txt` with natural unwrapped lines (and
the generated email no longer starts with the ASF license comment, which
`.licenserc.yaml`'s `*.txt` ignore makes possible); the two source-release
checklist items are restored; the completion log lists the remaining `<...>`
placeholders instead of "generated!".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
