mengw15 commented on code in PR #8592:
URL: https://github.com/apache/texera/pull/8592#discussion_r4044607435
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.ts:
##########
@@ -1526,6 +1526,17 @@ export class WorkflowFormComponent implements OnInit,
OnDestroy {
);
}
+ /** The embedded picker, asked for the warehouse requirement below: reading
its own predicate
+ * keeps this page and the canvas from drifting apart, as isConnecting does
for the socket. */
+ @ViewChild(ComputingUnitSelectionComponent) private unitSelection?:
ComputingUnitSelectionComponent;
+
+ /** Per-user warehouses are enabled and none is picked. The run would be
refused by
+ * ExecuteWorkflowService, so the button says so first, rather than
starting nothing and
+ * explaining afterwards in a toast (#8591). */
+ public get hasNoWarehouse(): boolean {
+ return this.unitSelection?.warehouseRequiredButMissing === true;
Review Comment:
Already gone in `18a345fe0`: the `ViewChild` and the picker's async
`warehouseEnabled` were replaced by the pair `ExecuteWorkflowService` itself
refuses on — the boot-time `config.env.warehouseEnabled` and the pick from
`WarehouseService`, both available synchronously. There is no window where the
button disagrees with the guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
