mengw15 opened a new pull request, #8592: URL: https://github.com/apache/texera/pull/8592
### What changes were proposed in this PR? The form view's run button enumerates every state a run cannot start from — invalid workflow, empty workflow, connecting, no computing unit, a read-only unit — so that, in its own words, "the reader is never sent to press a button that does nothing". The warehouse requirement added in #8551 was missing from that list: with the feature enabled and nothing picked, the button read `Run` and looked ready, and the click was refused deeper down in `ExecuteWorkflowService`, with a toast. It now names what is missing, ordered after the computing unit as the canvas orders them, and stays disabled — the warehouse is picked in the embedded selector, the same reasoning the no-unit case already gives. The predicate is the picker's own `warehouseRequiredButMissing`, read through the embedded component as the menu does, so this page and the canvas cannot drift apart. Flag off (the default): `warehouseRequiredButMissing` is never true, so the button behaves exactly as before. ### Any related issues, documentation, discussions? Closes #8591. Follows #8551. Part of #6870. ### How was this PR tested? - Two Vitest cases added: the button names the missing warehouse and stays disabled, and returns to `Run` once one is picked. The workspace suite passes in full: 3324 tests. - Failure path verified rather than assumed: the new case was removed on purpose and the suite confirmed to fail for the expected reason before being restored. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-5, claude-fable-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
