zyratlo commented on code in PR #8073:
URL: https://github.com/apache/texera/pull/8073#discussion_r3938224262
##########
common/config/src/test/scala/org/apache/texera/common/config/KubernetesConfigSpec.scala:
##########
@@ -86,6 +86,10 @@ class KubernetesConfigSpec extends AnyFlatSpec with Matchers
{
)
// Empty by default: only a real deployment knows its own origin.
ifUnset("KUBERNETES_JUPYTER_TEXERA_ORIGIN")(KubernetesConfig.jupyterTexeraOrigin
shouldBe "")
+ // A prefix, not a full path: the provisioner appends the uid.
+ ifUnset("KUBERNETES_JUPYTER_BASE_URL")(KubernetesConfig.jupyterBaseUrl
shouldBe "/jupyter")
+ // Empty by default: only a real deployment knows its own origin.
+
ifUnset("KUBERNETES_JUPYTER_TEXERA_ORIGIN")(KubernetesConfig.jupyterTexeraOrigin
shouldBe "")
Review Comment:
Removed in d48c79416. It was a merge artifact: the jupyter-texera-origin
assertion moved into #8032 during its review while this branch still carried
its own copy, and the two sat three lines apart so no merge ever collided. Each
KUBERNETES_JUPYTER_* setting is now asserted once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
