aglinxinyuan commented on code in PR #7351:
URL: https://github.com/apache/texera/pull/7351#discussion_r3739643382
##########
frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts:
##########
@@ -30,6 +30,13 @@ import { CustomJSONSchema7 } from
"../../../types/custom-json-schema.interface";
import { OperatorMetadataService } from
"../../../service/operator-metadata/operator-metadata.service";
import { StubOperatorMetadataService } from
"../../../service/operator-metadata/stub-operator-metadata.service";
import { FORM_DEBOUNCE_TIME_MS } from
"../../../service/execute-workflow/execute-workflow.service";
+
+/**
+ * Drains the short timers scheduled while the fixture is being set up, before
the form change
+ * under test. Unrelated to FORM_DEBOUNCE_TIME_MS, which is what the
assertions below actually wait
+ * on; this previously borrowed COLLAB_DEBOUNCE_TIME_MS (also 10ms) from an
unrelated component.
+ */
+const SETUP_FLUSH_MS = 10;
import { DatePipe } from "@angular/common";
Review Comment:
Agreed — moved in 60c641636c. `SETUP_FLUSH_MS` now sits below the import
block rather than between two import statements.
It landed there because it replaced an import: the constant used to be
`COLLAB_DEBOUNCE_TIME_MS`, pulled in from the component this PR deletes, and
defining it in place kept the diff small. That was the wrong tradeoff for a
line that stays in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
