aglinxinyuan opened a new issue, #7352:
URL: https://github.com/apache/texera/issues/7352

   ### Task Summary
   
   `OperatorMenuComponent` has 4 tests across 153 lines, and all four are about 
the search box. Two whole areas are untested.
   
   **The constructor's metadata subscription** is what actually populates the 
palette: it filters operator types out (`PythonUDF`, `Dummy`, and separately 
`Sleep`), buckets the rest by `operatorGroupName`, and sorts each bucket by 
`operatorType`. A regression there silently drops operators from the palette or 
reshuffles them, with nothing failing. Worth pinning: the bucketing, the 
per-group sort, that `groupNames` comes from the metadata rather than from the 
operators present, and that a filtered type is absent from **both** the palette 
and the search index — asserting only one would miss a filter applied in a 
single place.
   
   Note the `Sleep` handling is asymmetric: it is excluded from `opList` but 
left in the fuse collection, so it is searchable without being listed. The 
standard `StubOperatorMetadataService` fixture contains no `Sleep` operator, so 
exercising that needs a custom metadata provider.
   
   **`onSelectionChange` is untested entirely.** It places the new operator 
relative to the canvas pan offset (`400 - origin.tx`, `200 - origin.ty`), so 
the arithmetic deserves an assertion against a translated paper rather than an 
untranslated one. The `?? 0` fallbacks matter too — the paper is absent until 
the editor mounts. It then clears the search box inside a `setTimeout`, 
deliberately: ng-zorro re-displays the selected value if it is cleared 
synchronously, so a test should assert the value is *still set* immediately 
after the call and cleared only after the tick.
   
   Also uncovered: `canModify`, which tracks the workflow-modification stream. 
The palette disables drag-and-drop on that flag, so a stuck value lets a user 
drag operators onto a read-only workflow.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to