kz930 opened a new pull request, #7344:
URL: https://github.com/apache/texera/pull/7344
### What changes were proposed in this PR?
Sankey Diagram's value column is grouped by source and target and summed
into the width of each link, so it accepts only a number, but it declared no
`attributeTypeRules` and the form therefore offered every column. It now
declares `integer`, `long` or `double`, the way Range Slider's y-axis and Radar
Chart's value columns already do.
Source and target stay unconstrained: they are node labels, and any type
reads as one.
### Any related issues, documentation, discussions?
Closes #7319. Same class as #7341, for a different operator.
### How was this PR tested?
`SankeyDiagramOpDescSpec` passes. The behaviour the rule prevents was
reproduced first: with a string value column the group-and-sum concatenates
rather than adds, so a three-row frame reaches plotly as `link.value = ('ab',
'c')`, and plotly accepts non-numeric link values without raising — the diagram
renders with widths that mean nothing, and no error is reported anywhere. The
rule key was checked against the property it names, since a key matching no
property is silently inert (#7210); `Value Attribute` carries a space, which
the property editor handles the same way it already handles Range Slider's
`Y-axis`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
