kz930 opened a new pull request, #7343:
URL: https://github.com/apache/texera/pull/7343
### What changes were proposed in this PR?
Contour Plot's Grid Size is declared optional and the form shows a default
of 10, but the field itself starts empty and the generated code runs `int()` on
it unguarded. The field is now an `Option[Int]` that falls back to the
documented 10, and the number is emitted directly rather than wrapped in
`int()`.
`contentAs` names the boxed class because `Option` erases its element type;
without it a blank would read as 0 rather than as absent.
### Any related issues, documentation, discussions?
Closes #7212.
Split out of #7233, which covers the same numeric-settings gap in Bullet
Chart and Gauge Chart. Those two are validation being added — the operators
work when the value is right — whereas this one aborts with no wrong value
entered, so it is separated to be considered for the release on its own.
### How was this PR tested?
`ContourPlotOpDescSpec` covers it: the previous behaviour is that a freshly
dropped Contour Plot, with Grid Size untouched, generates `grid_size = int('')`
and aborts with `ValueError: invalid literal for int() with base 10: ''`. The
spec now asserts the generated code carries the numeric default, and that an
explicit value is emitted as itself.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
