gupta-sahil01 opened a new pull request, #7342:
URL: https://github.com/apache/texera/pull/7342
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
Clicking the trash icon next to a package in the dashboard **Environments**
page previously only marked the row (turned it red) via a `deleteToggle` flag;
the row wasn't dropped until the user clicked Save. A trash icon implies
immediate removal, so the interaction was ambiguous.
This PR replaces that toggle with an `nz-popconfirm` on the trash button. On
confirm the row is removed from the draft list; on cancel nothing changes.
- `togglePackageDelete(pkg)` → `removePackage(index)`, which splices the row
out of `currentDraft.newPackages`
- Dropped the now-unused `deleteToggle` field from `PveUserPackageRow` and
the `[class.highlighted-btn]` binding
- `saveEnvironment()` no longer needs to skip `deleteToggle` rows, since
removed rows are already gone from the draft
Save behaviour is unchanged: it still sends the full package map and the
backend performs the uninstall/install reconciliation as before. This is a
UI-only change — no backend or API changes.
Scoped deliberately to the dashboard Environments page ( `user-venv` ). The
computing-unit panel ( `computing-unit-selection` ) still uses the
mark-then-save pattern; happy to follow up there if that's wanted.
<img width="1279" height="400" alt="image"
src="https://github.com/user-attachments/assets/67e7e173-67bf-436d-9ec0-bb454af99580";
/>
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
### Any related issues, documentation, discussions?
Closes: #6937
Discussed in: #6725
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
### How was this PR tested?
Updated `user-venv.component.spec.ts`: replaced the `togglePackageDelete`
test with two for `removePackage` (removes the row at the given index; no-op
when there's no draft), and dropped the `deleteToggle` row from the save-path
test.
`cd frontend`
`npx ng test --include
src/app/dashboard/component/user/user-venv/user-venv.component.spec.ts
--watch=false`
25 tests pass. Also verified manually: the confirm dialog appears on the
trash icon, confirming removes only that row, cancelling leaves the list
unchanged, and Save persists the remaining packages.
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
