Yicong-Huang opened a new pull request, #6143: URL: https://github.com/apache/texera/pull/6143
### What changes were proposed in this PR? amber and workflow-compiling-service each maintained a separate copy of the workflow compiler and its models (`WorkflowCompiler`, `LogicalPlan`, `LogicalLink`, `LogicalPlanPojo`), which had to be kept in sync by hand. This PR consolidates them into a single shared `common/workflow-compiler` module that both services and amber depend on; the old per-service copies are removed. The unified `WorkflowCompiler.compile` returns a `WorkflowCompilationResult` (logical plan, optional physical plan, per-port output schemas, per-operator errors, and the output ports needing storage) and takes a `CompilationErrorHandling` mode: `Lenient` for the editing-time path (accumulate per-operator errors so the UI can render them) and `Strict` for the execution path (fail-fast before a run). amber's controller `Workflow` becomes a thin wrapper over the compilation result. ### Any related issues, documentation, discussions? Closes #6142. Design notes live in `common/workflow-compiler/DESIGN.md`. ### How was this PR tested? Migrated the compiler and model unit specs into the new module and added strict-mode coverage; amber and workflow-compiling-service compile and test against the shared library. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 (Claude Code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
