aglinxinyuan opened a new pull request, #6139: URL: https://github.com/apache/texera/pull/6139
### What changes were proposed in this PR? Adds a unit test for `AsyncRPCClient` (`amber` engine RPC), which had no dedicated spec. The test drives the client with directly-constructed collaborators (a real `NetworkInputGateway` and a `NetworkOutputGateway` whose handler captures messages) — no actor system, DB, or network — and covers the currently-uncovered paths: - `createInvocation` — carries method name/context, hands back an unfulfilled future, assigns monotonic command IDs, and `fulfillPromise` completes the future with the return value (and fails it on a `ControlError`); - `logControlReply` — all four branches: the `IgnoreReplyAndDoNotLog` early-return, the metrics early-return, the `ControlError` error path, and the null-`returnValue` info path; - `sendToClient` — forwards exactly one message to the client channel. No production code is changed; this is test-only. ### Any related issues, documentation, discussions? Coverage gaps identified from the Codecov report for `apache/texera`. ### How was this PR tested? New ScalaTest spec, run locally: ``` sbt "WorkflowExecutionService/testOnly *AsyncRPCClientSpec" ``` All 11 pass. `scalafmt` and `scalafixAll --check` are clean. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
