aglinxinyuan opened a new pull request, #6057:
URL: https://github.com/apache/texera/pull/6057

   ### What changes were proposed in this PR?
   
   Fill uncovered code paths in three `workflow-operator` classes, selected 
from the Codecov report. No production-code changes.
   
   | File | Codecov before | Missed lines targeted |
   | --- | --- | --- |
   | `FilterPredicate.java` | 40.0% | 26 — the remaining `evaluate` branches: 
GE/LT operators, null-field short-circuit, IS_NULL both ways, boolean 
(case-insensitive), double, long, and timestamp evaluators, the numeric-string 
fast path, and the `equals` identity/null/other-type branches |
   | `BufferedBlockReader.java` | 0% | 51 (whole class) — delimiter splitting, 
EOF flush (incl. kept-filter bypass), CR terminators and the CRLF single-null 
artifact, empty fields → null, fields spanning buffer reads, 
delimiter-at-buffer-start carry, kept-index filtering, `hasNext` block-boundary 
semantics, `close` |
   | `DualInputPortsPythonUDFOpDescV2.scala` | 40.0% | 27 — the entire 
`getPhysicalOp`: worker precondition, env-name resolution 
(default/blank-reject/trim), single vs parallel wiring, unknown-partition 
derivation, and the port-1-drives-output schema propagation incl. the 
duplicate-column rejection |
   
   Extends the existing `FilterPredicateSpec` and adds 
`BufferedBlockReaderSpec` (with a chunked-stream stub to force buffer-boundary 
paths) and `DualInputPortsPythonUDFOpDescV2Spec`.
   
   ### Any related issues, documentation, discussions?
   
   Follow-up to the review feedback on #6043: prioritize tests that fill 
uncovered code paths.
   
   ### How was this PR tested?
   
   - `sbt "WorkflowOperator/testOnly *FilterPredicateSpec 
*BufferedBlockReaderSpec *DualInputPortsPythonUDFOpDescV2Spec"` — 39 tests, all 
green
   - `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt 
"WorkflowOperator/scalafixAll --check"` — clean
   - CI + Codecov delta to confirm
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to