aminghadersohi commented on code in PR #35018: URL: https://github.com/apache/superset/pull/35018#discussion_r2334077828
########## requirements/development.in: ########## @@ -16,5 +16,5 @@ # specific language governing permissions and limitations # under the License. # --e .[development,bigquery,druid,duckdb,gevent,gsheets,mysql,postgres,presto,prophet,trino,thumbnails] +-e .[development,bigquery,druid,duckdb,gevent,gsheets,mysql,postgres,presto,prophet,pydantic,trino,thumbnails] Review Comment: ah yeah that makes sense. pydantic gets pulled as a part of fastmcp. This PR doesn't have fastMCP dep requirement but it does add pydantic usage to base dao. It wasn't really possible to keep using marshmallow because the mcp service uses the pydantic models directly and/or extends them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
