aminghadersohi commented on PR #35018: URL: https://github.com/apache/superset/pull/35018#issuecomment-3266806587
> Few small nits but overall solid code pushing the right logic where it belongs, excited to see base classes get strengthened up and more test coverage! > > Wondering if this refactor means some code in the derived classes will automatically benefit or whether we could push subclasses to use the new methods(?) Thanks! The added code does not affect existing usages of daos - so subclasses don't use this code yet. I think a future refactor would be beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
