mistercrunch commented on code in PR #34876:
URL: https://github.com/apache/superset/pull/34876#discussion_r2323626822


##########
superset-frontend/packages/superset-ui-core/src/theme/types.ts:
##########
@@ -127,6 +127,15 @@ export interface SupersetSpecificTokens {
   // Spinner-related
   brandSpinnerUrl?: string;
   brandSpinnerSvg?: string;
+
+  // ECharts-related
+  /** Global ECharts configuration overrides applied to all chart types */
+  echartsOptionsOverrides?: any;

Review Comment:
   I looked into doing this early on but bailed, but any component could define 
its namespace and read from it with something like:
   ```
   # in say EchartPieChart
   const theme = useThemeWithComponentOverrides("EchartPieChart");
   # ^^^ returns a full theme object with EchartPieChart overrides applied.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to