villebro commented on code in PR #34876:
URL: https://github.com/apache/superset/pull/34876#discussion_r2322728503
##########
superset-frontend/packages/superset-ui-core/src/theme/types.ts:
##########
@@ -127,6 +127,15 @@ export interface SupersetSpecificTokens {
// Spinner-related
brandSpinnerUrl?: string;
brandSpinnerSvg?: string;
+
+ // ECharts-related
+ /** Global ECharts configuration overrides applied to all chart types */
+ echartsOptionsOverrides?: any;
Review Comment:
I like @rusackas 's thinking here. I suspect we may need to be open to doing
some exploration here, as finding the ultimate solution upfront may be
challenging. So as a compromise, maybe we could let this logic in, with the
caveat that this is highly experimental, and will likely break in future
iterations.
> Suppose we make the theme itself extendible and use keys like
echartsOptionsOverrides etc. If user wants to create a viz plugin they just
need to extend the theme with their own keys like d3ChartsOptions and merge the
options there just like Max did here with Echarts. That looks like a simple and
straightforward flow to me.
@msyavuz I'm not convinced this will work. Different viz libraries apply
overrides differently. For instance, ECharts is declarative with a single huge
"option" object, while eg. D3 has a much more imperative API, with lots of
chained function calls to arrive at the final chart. So applying similar
changes on D3 will likely require a very different approach to ECharts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
