Vitor-Avila commented on code in PR #34988:
URL: https://github.com/apache/superset/pull/34988#discussion_r2324075448
##########
superset/dashboards/api.py:
##########
@@ -1204,6 +1205,10 @@ def screenshot(self, pk: int, digest: str) ->
WerkzeugResponse:
image = cache_payload.get_image()
except ScreenshotImageNotAvailableException:
return self.response_404()
+
+ filename = get_filename(
+ dashboard.dashboard_title, dashboard.id, skip_id=True
Review Comment:
ok, I manually tested this and it turns out that this is correct.
Technically you can create a dashboard with a `POST api/v1/dashboard` with
payload set to `{}` and that would break `get_filename()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
