Vitor-Avila opened a new pull request, #34988:
URL: https://github.com/apache/superset/pull/34988
### SUMMARY
The client-side generated dashboard PDF/PNG download would use the dashboard
title as the filename (with the timestamp). The backend generation would always
produce a file named `screenshot.${format}` which is not ideal.
This PR improves the backend generation to use the dashboard title.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1909" height="935" alt="image"
src="https://github.com/user-attachments/assets/10c89cb7-8694-4272-b841-fdb0da8df7a6";
/>
### TESTING INSTRUCTIONS
Integration test added. For manual testing:
1. Make sure you have caching, celery and Selenium/Playwright running.
2. Enable all required FFs to generate screenshots via the backend.
3. Trigger a PDF/PNG download of a dashboard, and confirm the suggested file
name.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
