Vitor-Avila commented on code in PR #34665:
URL: https://github.com/apache/superset/pull/34665#discussion_r2288574231
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -184,6 +184,7 @@ const SliceHeaderControls = (
props.slice.datasource,
props.dashboardId,
props.formData,
+ !canDrillToDetail,
Review Comment:
@michael-s-molina I agree your suggestion looks a lot better, and also that
the caller should decide if the request is needed or not. However, that would
be a conditional hook, which then raises on `pre-commit`.
I believe the ideal/long-term solution would be to refactor this whole flow,
but for now hopefully this `skip` param is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
