msyavuz commented on code in PR #34665:
URL: https://github.com/apache/superset/pull/34665#discussion_r2274612327
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -184,6 +184,7 @@ const SliceHeaderControls = (
props.slice.datasource,
props.dashboardId,
props.formData,
+ !canDrillToDetail,
Review Comment:
Only improvement i could think of at first is to move `useDatasetDrillInfo`
inside the actual components but not sure if it's an improvement at all. I
think having a skip argument is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
