Antonio-RiveroMartnez commented on code in PR #34769:
URL: https://github.com/apache/superset/pull/34769#discussion_r2287179756
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -1076,6 +1076,55 @@ def test_get_chart_not_found(self):
rv = self.get_assert_metric(uri, "get")
assert rv.status_code == 404
+ def test_slice_get_by_id(self):
Review Comment:
Yes, I mean, looking at the tests you can assert both things just with 1
extra assertion that's why I suggested merging them, but the ultimate goal is
to DRY them because those tests are 95% the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
