Antonio-RiveroMartnez commented on code in PR #34769: URL: https://github.com/apache/superset/pull/34769#discussion_r2287093550
########## tests/unit_tests/models/slice_test.py: ########## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import uuid +from unittest.mock import MagicMock, patch + +import pytest + +from superset.models.slice import id_or_uuid_filter, Slice + + +class TestSlice: Review Comment: Same comment from above ########## tests/integration_tests/charts/api_tests.py: ########## @@ -1076,6 +1076,55 @@ def test_get_chart_not_found(self): rv = self.get_assert_metric(uri, "get") assert rv.status_code == 404 + def test_slice_get_by_id(self): Review Comment: Could we merge these tests together and avoid duplication? both for the success and non existent ones -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
