villebro commented on PR #33837: URL: https://github.com/apache/superset/pull/33837#issuecomment-3161521288
I'm not clear on why we'd want this change. IMO it adds unnecessary complexity to do something that can be done in local CI/CD pipelines. For instance, you could lint your helm repo to error out if a SQLA connection string doesn't have the required URL params. I agree that this change is not problematic in itself, especially if this is universally useful, but over time these types of customizations tend to add up, and add to maintenance burden unnecessarily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
