nathanjrobertson commented on PR #33837: URL: https://github.com/apache/superset/pull/33837#issuecomment-3152785143
> decide whether it's just "a reference implementation that works well and is bulletproof" VS "an abstraction that allows you to configure your system in all sorts of ways" I understand what you're saying. I think this PR is trivial enough that it is compatible with both. The existing functionality assumes PostgreSQL, but explicitly allows you to turn off the built-in Postgres instance and use your own external one. Without SSL support (added by this PR) the existing functionality doesn't work at all on kubernetes vendors who require SSL to be switched on to be able to connect to their managed database solution (eg DigitalOcean, I'd imagine other vendors have the same sane default). Hence, the current implementation doesn't work well in a best practice industry standard environment. This PR brings it one step closer to supporting other databases (removing the hard coding of PostgreSQL in the database URI is the next step). So, if that's the goal, this PR gets us one step closer. Summary - this PR fixes a current issue with supported functionality if the goal is a reference bulletproof implementation, and a step in the right direction if the goal is something broader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
