Quatters commented on PR #34323: URL: https://github.com/apache/superset/pull/34323#issuecomment-3122034170
> it would be clearer to name the default not "None", but "Sort by metric" because the sorting will be from the series Yes, it will be from the series, but by metric only if checkbox is set. I think more natural variant to have Asc/Desc options and to make select clearable. By default it's not set (`undefined`). In this case we also avoid translating "None" which in other languages can have slightly different meaning depending on context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
