SBIN2010 commented on PR #34323:
URL: https://github.com/apache/superset/pull/34323#issuecomment-3121508407
> Hi, @SBIN2010, thanks for contribution!
>
> It seems to me that legend should have the same sorting as data.
>
> In general, I think the most obvious solution would be to provide two
options for sorting ("Metric", "Name"), and a checkbox for ascending or
descending order, similar how `sortSeriesType` and `sortSeriesAscending`
controls work. But Pie chart already has "Sort by metric" control which in this
case should be remove, and this will require a migration...
>
> @michael-s-molina @rusackas @mistercrunch what do you think?
Thanks for the feedback.
But the idea in such an implementation is to separate the sorting of the
series and the sorting of the legend.
From your reasoning, I got the idea that it would be clearer to name the
default not "None", but "Sort by metric" because the sorting will be from the
series
@michael-s-molina @rusackas @mistercrunch what do you think about this
division and the choice names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
