msyavuz commented on code in PR #34311:
URL: https://github.com/apache/superset/pull/34311#discussion_r2231773322
##########
superset-frontend/plugins/plugin-chart-table/src/Styles.tsx:
##########
@@ -152,11 +152,19 @@ export default styled.div`
padding-top: 0.5em;
}
+ .dt-pagination .pagination > li {
+ list-style: none;
+ display: inline;
+ margin: 0 5px;
+ }
+
.dt-pagination .pagination > li > a,
.dt-pagination .pagination > li > span {
background-color: ${theme.colorBgBase};
color: ${theme.colorText};
border-color: ${theme.colorBorderSecondary};
+ padding: 5px 10px;
+ border-radius: 4px;
Review Comment:
Same here
##########
superset-frontend/plugins/plugin-chart-table/src/Styles.tsx:
##########
@@ -152,11 +152,19 @@ export default styled.div`
padding-top: 0.5em;
}
+ .dt-pagination .pagination > li {
+ list-style: none;
+ display: inline;
+ margin: 0 5px;
Review Comment:
Can we use theme variables instead? Something like `theme.marginXXS`? You
can find the similar usages in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]