Re: [PR] style(chart): restyle table pagination [superset]

Thu, 24 Jul 2025 22:07:29 -0700 


korbit-ai[bot] commented on code in PR #34311:
URL: https://github.com/apache/superset/pull/34311#discussion_r2230148040


##########
superset-frontend/plugins/plugin-chart-table/src/Styles.tsx:
##########
@@ -152,11 +152,19 @@ export default styled.div`
       padding-top: 0.5em;
     }
 
+    .dt-pagination .pagination > li {
+      list-style: none;
+      display: inline;
+      margin: 0px 5px 0px 5px
+    }

Review Comment:
   ### Inconsistent CSS syntax in pagination styles <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The margin shorthand property is missing a semicolon at the end of the 
declaration and uses inconsistent unit notation (0px vs 5px).
   
   
   ###### Why this matters
   Missing semicolons can lead to CSS parsing errors in some environments, and 
inconsistent unit notation makes the code less maintainable and harder to read.
   
   ###### Suggested change ∙ *Feature Preview*
   ```css
   .dt-pagination .pagination > li {
         list-style: none;
         display: inline;
         margin: 0 5px;
       }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9291256f-462d-406f-b02a-d99e7b9f4932/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9291256f-462d-406f-b02a-d99e7b9f4932?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9291256f-462d-406f-b02a-d99e7b9f4932?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9291256f-462d-406f-b02a-d99e7b9f4932?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9291256f-462d-406f-b02a-d99e7b9f4932)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:8a2559fa-06a4-4873-ba84-0b203d5fa347 -->
   
   
   [](8a2559fa-06a4-4873-ba84-0b203d5fa347)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to