Habeeb556 commented on PR #34235: URL: https://github.com/apache/superset/pull/34235#issuecomment-3104701000
Awesome! This PR covers two important parts: 1- The first part is about manually encoding the response — which I originally opened this PR for. Even when setting `utf-8-sig`, it wasn’t working correctly due to changes in **Werkzeug 3**, which now requires manual handling of response encoding. 2- The second part, which you suggested (and I agree with), is to use `utf-8-sig` by default to support the BOM and make things work out of the box — especially for Excel compatibility. As for removing the config option, I would suggest we **keep it** for flexibility, so users can still choose a different encoding if needed. But yes, we should **update the default to `utf-8-sig`** to avoid issues and support international characters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
