Habeeb556 commented on PR #34235: URL: https://github.com/apache/superset/pull/34235#issuecomment-3098047426
> Looks like some unit tests are failing... Not sure this won't break anything for anyone out there. Due to a **type mismatch**, the test is comparing a **byte string** (`b'foo\n1\n2\n'`) with a **regular string** (`'foo\n1\n2\n'`), which will always fail in Python. The test assumes the function returns a string, which is fine for displaying data. However, since the actual export returns **bytes** (raw binary data)—as expected for file downloads—the test should be updated to expect bytes instead. Additionally, as noted in Werkzeug issue https://github.com/pallets/werkzeug/issues/3057, **automatic encoding was disabled in Werkzeug 3**, so this now needs to be handled manually. That’s what I have implemented here. While downgrading to `Werkzeug==2.3.8` does resolve the issue temporarily, it's not ideal. That version was flagged in issue #28623 due to a **CVE**, so relying on it long-term would be risky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
