sadpandajoe commented on code in PR #34213:
URL: https://github.com/apache/superset/pull/34213#discussion_r2214513272
##########
superset/utils/core.py:
##########
@@ -1503,6 +1514,71 @@ def get_column_names_from_metrics(metrics: list[Metric])
-> list[str]:
return [col for col in map(get_column_name_from_metric, metrics) if col]
+def map_sql_type_to_inferred_type(sql_type: Optional[str]) -> str:
Review Comment:
I see new functions here, are there already tests for these new functions
somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
