LisaHusband opened a new pull request, #34213:
URL: https://github.com/apache/superset/pull/34213

   
   ### SUMMARY
   
   The issue occurs when a table with numeric columns containing only NULL 
values is used in an Interactive table or Table chart. These columns were 
mistakenly categorized as string columns when configuring the chart, due to the 
NULL values. This PR fixes the issue by ensuring that columns with numeric data 
types, even when containing only NULL values, are correctly categorized as 
numeric in the Customize tab of the chart.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   *Before:*
   The numeric columns with NULL values were incorrectly categorized as string 
columns, leading to inaccurate chart behavior.
   
   *After:*
   The numeric columns with NULL values are correctly identified as numeric 
columns, ensuring accurate chart rendering.
   
   ### TESTING INSTRUCTIONS
   
   1. Create a table with at least one numeric column.
   2. Insert NULL values into the numeric column.
   3. Create a dataset using the table.
   4. Edit the dataset and create a metric using the numeric column.
   5. Create an Interactive table chart or Table chart using the dataset.
   6. Move the created metric to the metrics section and add one column to the 
dimension section.
   7. Click the "Update chart" button, and navigate to the "Customize" tab.
   8. Verify that the numeric column is correctly categorized as numeric and 
not as a string column.
   
   ### ADDITIONAL INFORMATION
   
   * [x] Has associated issue: #34136 (replace with actual issue number)
   * [ ] Required feature flags: None
   * [ ] Changes UI: Yes
   * [ ] Includes DB Migration (follow approval process in 
[[SIP-59](https://github.com/apache/superset/issues/13351)](https://github.com/apache/superset/issues/13351))
   
     * [ ] Migration is atomic, supports rollback & is backwards-compatible
     * [ ] Confirm DB migration upgrade and downgrade tested
     * [ ] Runtime estimates and downtime expectations provided
   * [ ] Introduces new feature or API: No
   * [ ] Removes existing feature or API: No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to