mistercrunch commented on code in PR #34119:
URL: https://github.com/apache/superset/pull/34119#discussion_r2205506539
##########
superset-frontend/src/preamble.ts:
##########
@@ -19,65 +19,81 @@
import { setConfig as setHotLoaderConfig } from 'react-hot-loader';
import dayjs from 'dayjs';
// eslint-disable-next-line no-restricted-imports
-import { configure, makeApi, initFeatureFlags } from '@superset-ui/core';
+import {
+ configure,
+ makeApi,
+ initFeatureFlags,
+ SupersetClient,
+ LanguagePack,
+} from '@superset-ui/core';
import setupClient from './setup/setupClient';
import setupColors from './setup/setupColors';
import setupFormatters from './setup/setupFormatters';
import setupDashboardComponents from './setup/setupDashboardComponents';
import { User } from './types/bootstrapTypes';
import getBootstrapData, { applicationRoot } from './utils/getBootstrapData';
+configure();
Review Comment:
I'm unclear what exactly it does, but it prepares a bunch of things around
the various "registries" and such. Might be worth digging a bit deeper. I'll
double check there's no important perf costs in calling it twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
