korbit-ai[bot] commented on code in PR #34119: URL: https://github.com/apache/superset/pull/34119#discussion_r2196883221
########## superset-frontend/src/preamble.ts: ########## @@ -1,83 +1,99 @@ /** * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file + * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the + * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ + import { setConfig as setHotLoaderConfig } from 'react-hot-loader'; import dayjs from 'dayjs'; // eslint-disable-next-line no-restricted-imports -import { configure, makeApi, initFeatureFlags } from '@superset-ui/core'; +import { + configure, + makeApi, + initFeatureFlags, + SupersetClient, +} from '@superset-ui/core'; import setupClient from './setup/setupClient'; import setupColors from './setup/setupColors'; import setupFormatters from './setup/setupFormatters'; import setupDashboardComponents from './setup/setupDashboardComponents'; import { User } from './types/bootstrapTypes'; import getBootstrapData, { applicationRoot } from './utils/getBootstrapData'; +configure(); Review Comment: ### Redundant Initial Configuration <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? Initial configure() call is unnecessary as it's followed by another configure() call with the language pack. ###### Why this matters The redundant configure() call could potentially reset or interfere with configuration settings before the actual language pack is loaded. ###### Suggested change ∙ *Feature Preview* Remove the initial configure() call as it's not needed: ```typescript // Remove this line // configure(); ``` ###### Provide feedback to improve future suggestions [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/34f03d23-410c-4fd6-b018-64350e3b9e71/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/34f03d23-410c-4fd6-b018-64350e3b9e71?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/34f03d23-410c-4fd6-b018-64350e3b9e71?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/34f03d23-410c-4fd6-b018-64350e3b9e71?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/34f03d23-410c-4fd6-b018-64350e3b9e71) </details> <sub> 💬 Looking for more details? Reply to this comment to chat with Korbit. </sub> <!--- korbi internal id:ad45a5e2-b080-4f5b-8ac4-ef4d2b944ef3 --> [](ad45a5e2-b080-4f5b-8ac4-ef4d2b944ef3) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
