Re: [PR] style(Button): Vertically align icons across all buttons and remove box shadow [superset]

Mon, 07 Jul 2025 08:52:13 -0700 


EnxDev commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2190441291


##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -774,10 +774,17 @@ function ChartList(props: ChartListProps) {
   if (canCreate) {
     subMenuButtons.push({
       name: (
-        <>
+        <span

Review Comment:
   **Regarding the icon alignment:** 
   In this case, the icon has a font-size of 14px, while the text to its right 
has a font-size of 12px, which causes a slight misalignment.
   
   By adding display: flex to the <span> that wraps the icon, the icon becomes 
vertically centered.
   In the screenshot below, the button on the right uses display: flex on the 
icon container span, which has the `.ant-btn-icon class` 
   
   ![Screenshot 2025-07-07 
173848](https://github.com/user-attachments/assets/3e71d55a-b85f-450f-86de-5e78a356ea00)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to