EnxDev commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2190406356
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -774,10 +774,17 @@ function ChartList(props: ChartListProps) {
if (canCreate) {
subMenuButtons.push({
name: (
- <>
+ <span
Review Comment:
Aware of the upcoming release, I noticed that the change could introduce
regressions. For this reason, I decided to go with a temporary, suboptimal
solution.
I agree with you that the icon property can be used, except in cases where a
tooltip is involved, given the current structure of the array of objects.
For now, I think it's fine to keep the current approach (an array of config
objects with icon key), unless you think it's worth doing a refactor and
switching to an array of <Button /> components instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
