amaannawab923 commented on PR #33517: URL: https://github.com/apache/superset/pull/33517#issuecomment-2967133807
> > Migration should be pretty easy going forward > > @amaannawab923 Just to be clear, there are multiple migrations: > > 1. Migrating `plugin-chart-table` to `plugin-chart-ag-grid-table` > 2. Extracting common parts of `plugin-chart-ag-grid-table` and `GridTable` (used in SQL Lab) into a component in core to avoid code duplication > 3. Replace `src/components/Table` with the core implementation > > Ideally, we would have a single table component inside core that could be extended to deal with specific things like extra plugin configurations, SQL Lab specific things, etc. Agreed , i will try my best to wrap up all the migrations in the follow up pr Thanks for listing it down , Will make a note of it & try my best to take care of all of the points Thanks @michael-s-molina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
